-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Python] Test printing unicode characters #3563
Conversation
dbrattli
commented
Oct 22, 2023
•
edited
Loading
edited
- Print unicode character to make sure printing does not blow up
- Code cleanup and formatting
If they don't run there are no errors, so it means that it works 😏 More seriously, I have PR testing a fix for the Python tests on windows here #3569 Waiting for it to run and will merge it if all is fine. |
ea655a8
to
73d48d5
Compare
I rebased this PR to the latest version of main which as the CI fix in it. |
While it doesn't show the character it doesn't seem to blow up. Puzzling. |
I think it could be interesting to check if this is also the case when running it on a local Windows machine with different terminals like Cmd, Windows Terminal, Git bash, etc. Just to check if this is not just a problem of encoding based on the terminal used by the CI |
@dbrattli Which formatter are you using for Python code? This is so I can install it on my machine too when contributing to the python code. |
@MangelMaxime I'm using |
Ok thank you @dbrattli. I think one of the next thing I want to add to the repo is auto format of the different source code when possible, just so we all write the same things. And it will also clean up some of the files who use odd formatting rules |
@MangelMaxime I'll open an issue on this topic so we can discuss more |